mirror of
https://github.com/Dingo-Shenanigans/ReSkate.git
synced 2026-10-18 17:55:28 +02:00
AyeZeeBB
1004e012bf
A player whose game sat under a folder named U+200E (left-to-right mark, an invisible directory on their Desktop) could not launch: the status tile read "No mapping for the Unicode character exists in the target multi-byte code page". Nothing was wrong with their mods, and the merge in their log had just succeeded. fs::path::string() converts to the process's ANSI code page and throws exactly that when a character has no mapping there. initfs.cpp called it on the normal path, not in an error handler, so exporting loose files threw on every launch. Their log stops right where that export begins. Cyrillic, CJK or accented characters in an install path do the same on a code page that cannot hold them. - path_utf8() in Engine/Core/Platform/path_text.h: UTF-8 represents every path Windows allows, so it never throws. - Every path that becomes a narrow string uses it -- 35 of them across 13 files. Most are log lines and error messages, which were a second trap: reporting a problem with a path threw this instead of the problem. - The ~45 .string() calls on Json values are untouched; those are not paths. Nothing changes for an ASCII path, where both encodings agree, and a path that is not ASCII had no working behaviour to preserve. Reported with a log by a player on Discord. Moving the game to an ordinary folder works around it on an unpatched build.
26 lines
907 B
C++
26 lines
907 B
C++
#pragma once
|
|
|
|
#include <filesystem>
|
|
#include <string>
|
|
|
|
namespace dingosdk {
|
|
|
|
// A path as narrow text.
|
|
//
|
|
// std::filesystem::path::string() converts to the process's ANSI code page and
|
|
// throws when a character has no mapping there: "No mapping for the Unicode
|
|
// character exists in the target multi-byte code page". A folder named in
|
|
// Cyrillic or CJK is enough, and so is an invisible one -- a directory called
|
|
// U+200E (left-to-right mark) has been seen in the wild. The failure lands far
|
|
// from the cause, because the path is usually only being written into a log or
|
|
// an error message at the time.
|
|
//
|
|
// UTF-8 can represent every path Windows allows, so every path that becomes a
|
|
// narrow string goes through here instead.
|
|
inline std::string path_utf8(const std::filesystem::path& path) {
|
|
const auto text = path.u8string();
|
|
return {text.begin(), text.end()};
|
|
}
|
|
|
|
} // namespace dingosdk
|