19 Commits
Author SHA1 Message Date
xshxdex98 7df9be7785 Give unset locals values, and drop the decompiler's dated audit notes
25 notes ("left unassigned only by this default arm ... approval pending,
2026-09-27 audit") argued that a variable was never read unset. Where the
arm ends in system_exit they were right and simply go. A release build's
assertions return, though, so where the arm only asserts the variable now
starts with a value (a Custom Edition map's HUD data can reach hud_draw's).
A failed map precache reads as failed.

rasterizer_debug_drawing_begin had two declarations, one with an argument
its definition never takes; it now has one, and the port's macro papering
over the mismatch is gone.

(cherry picked from commit 74f8a048e4c3cc7dbc4b050dd41a8bae912bb367)
2026-10-10 12:53:22 +13:00
Jonas Volman f3aadeab98 Reconcile five Halo functions and approved declaration batches
Integrate coherent B3, P2/K17 prerequisites, completed K1-K16 + S, and the independent profile/effects rulings. Five gains and two explicitly approved B3 debits: net +3 strict functions, +2770 meaningful/+2800 padded bytes (+2774 progress credit). No additional losses; Halo objects 394 to 396 and data unchanged.

Clean rebuild, identical 8252-row stable sweep, 68 valid parks, admission/provider checks, 467-unit warning comparison, unchanged fake scan, and 1318 tests passed. Preserve canonical helper recoveries and unrelated work. Full evidence and disclosures in docs/object_matching_logs/astra_five_function_reconciliation_20260928.md.
2026-09-28 23:17:10 -07:00
Jonas Volman 59757f4263 Reconcile approved type ownership, static locals and source disclosures
Independently gate storage + K, OQ-4 P-a/P-b1, four static-local packets and comment-only disclosures. Preserve all 7641 exact owner rows, 71 valid parks and 1161 passing tests; code/data credit unchanged. G and game_engine admission remain held because current canonical loses populate_statistic_buffer. Existing collision static-local repair is not duplicated. No donor tree, held candidate, scorer or private asset imported.
2026-09-27 05:17:27 -07:00
Jonas Volman 4f4c85021d Reconcile Lane C with canonical house-rule audit
Integrate verified source and data progress; exclude unproven COMMON ownership, held UB/asm forms, and address-named data credit. Stable sweep: 23 exact functions gained, zero lost.
2026-09-22 23:12:40 -07:00
Jonas Volman 5361eeae52 Reconcile Astra exact-match campaign (+8314 bytes)
Integrate six accepted exact functions, two whole-object admissions, evidence-backed zero-credit source corrections, owner-header cleanup, and curated campaign records. Preserve zero regressions and exclude generated scratch archives from canonical history.
2026-09-20 02:31:53 -07:00
Jonas Volman 9d155f1d60 Admit ten verified exact objects 2026-09-19 15:56:43 -07:00
Jonas VolmanandClaude Opus 5 33985aa2a0 Wave 11: two functions strict exact (dsound, bitmap_extract)
- _dsound_initialize: one final success/dispose block instead of four
  per-arm dsound_dispose calls; create_inanity_channel chained into the
  success flag like the channel loops
- _extract_build_texture_pages_by_sequence: begin the selected texture
  page once after the page-selection if/else (park reopen)

Rejected: _player_control_modify_desired_angles (factor order selected
from a 12-order search - operand permutation steering; owner-ruling
queue), _compute_sound_obstruction (new _vector_from_points3d COMDAT,
pending owner ruling), _update_potentially_audible_looping_sound
(duplicated arm stores), _path_avoid_obstacles and
_render_debug_obstacle_path (unauthenticated .bss label names).
Stable diff: 0 regressions; active parks 223 -> 222.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-16 18:56:43 -07:00
Jonas VolmanandClaude Opus 5 57fc56c467 bitmap_extract: 1 function(s) strict exact
Wave w3 landing, adversarially verified. park reopens: _extract_sprites. Full ninja build and per-function stable_verdicts sweep: 0 regressions. 1 park(s) removed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 14:45:17 -07:00
Jonas VolmanandClaude Opus 5 1f2c40aef1 bitmap_extract: 2 function(s) strict exact
Wave w1 landing, adversarially verified. park reopens: _extract_plateless_cube_map, _extract_get_bitmap_format. Full build of the combined batch: 54 strict gains / 29,440 padded, 0 regressions, parks 355/0/0. 2 park(s) removed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 02:50:19 -07:00
Jonas VolmanandClaude Opus 5 94f7bbb80c Restore bitmap_data/bitmap_group owner types and bitmap helper prototypes; reopen five bitmap_extract parks exact
bitmap_group.h: signed depth/mipmap_count and union point2d registration_point (HCEA types, January movsx reads and whole-point copies), respelled in its four consumers. bitmaps_mipmap.h declares bitmap_get_max_mipmap_count (fixes an implicit declaration); bitmap_group_internal.h declares bitmap_group_add_bitmap (bitmap_group.h placement regressed decals by declaration count). bitmap_compress_to_mipmap takes the transparent-colour reference pointer January passes. Header renames and their consumers are one measured packet. Unparks _extract_add_bitmap, _extract_build_debug_plate, _extract_mipmaps_to_bitmap, _extract_pixels_from_mipmap, _extract_pixels_to_mipmap (+4,544 padded); re-baselines parked _bitmap_group_add_bitmap (same 992/59). Adversarially verified; 45 bitmap_group.h consumers rebuilt, 0 regressions.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 21:37:53 -07:00
Jonas VolmanandClaude Opus 5 7de4936046 bitmap_extract: reopen extract_bitmap, bitmaps_extract, cube_maps, 3d_textures and border warning exact
Documented criteria met: extract_add_bitmap and the private extraction callees are now reconstructed in this TU. Single-exit result flags, January assert spellings and 16-bit indices; extract_cube_maps keeps January's freed-pointer bug (commented). extract_sequence stays parked because its exact form reproduces redundant logic (verifier rejected). 5 parks removed; +5 exact (3,040 padded). Full build of the combined reopen set: 0 regressions, parks 451/0/0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 21:26:07 -07:00
Jonas Volman d6250fa794 Reconcile sixth 10K exact source batch 2026-09-12 12:36:44 -07:00
Jonas Volman a565219da1 Reconcile fifth 10K exact source batch 2026-09-09 22:29:33 -07:00
Jonas Volman db720270ec Reconcile HUD bitmap retrieval pair 2026-09-09 07:05:53 -07:00
Jonas Volman e0182f0973 Document preserved bitmap extraction edge 2026-09-03 06:15:43 -07:00
Jonas Volman daf6e7c8b6 Audit bitmap extraction private helpers 2026-09-03 06:14:02 -07:00
Jonas Volman 55854f5f78 Reconstruct bitmap 3D texture extraction 2026-09-03 06:14:02 -07:00
Jonas Volman d16d99f1b3 Reconstruct bitmap extraction core 2026-09-02 18:12:11 -07:00
punpckhdq e830efbd7c Initial commit 2025-11-27 02:27:27 +00:00