From 86684f90334efea77574b942eabf80690edb7989 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Fri, 26 Nov 2021 23:52:38 -0800 Subject: [PATCH] FEXLoader: Change 32-bit memory check error to warning Instead of early exiting, allow the application to continue running but throw error messages anyway. Should allow some users to still run FEX even if an application steals a page in the lower 32-bits --- Source/Tests/FEXLoader.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Source/Tests/FEXLoader.cpp b/Source/Tests/FEXLoader.cpp index fb8d03960..2c358f879 100644 --- a/Source/Tests/FEXLoader.cpp +++ b/Source/Tests/FEXLoader.cpp @@ -137,10 +137,10 @@ void PrintIntersectingMapping() { if (sscanf(Line.c_str(), "%lx-%lx", &Begin, &End) == 2) { // If a memory range is living inside the 32bit memory space then we have a problem if (Begin < 0x1'0000'0000) { - LogMan::Msg::EFmt("*** {}", Line); + LogMan::Msg::DFmt("*** {}", Line); } else { - LogMan::Msg::EFmt(" {}", Line); + LogMan::Msg::DFmt(" {}", Line); } } } @@ -376,8 +376,7 @@ int main(int argc, char **argv, char **const envp) { if (!getenv("VALGRIND_LAUNCHER") && !CheckMemMapping()) { PrintIntersectingMapping(); - LogMan::Msg::EFmt("[Unsupported] FEX mapped to lower 32bits! Exiting!"); - return -1; + LogMan::Msg::DFmt("[WARNING] FEX mapped to lower 32bits! 32-bit applications may have issues!"); } #endif