From b4cde28137010ad2dd69fbca6a26bb707a3fc67d Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 9 Jun 2021 20:19:17 -0400 Subject: [PATCH] SignalDelegator: Move virtual destructor to base class Ensures that destruction behavior will always handle the polymorphic case, no matter where it occurs in the hierarchy. --- External/FEXCore/include/FEXCore/Core/SignalDelegator.h | 2 ++ Source/Tests/LinuxSyscalls/SignalDelegator.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/External/FEXCore/include/FEXCore/Core/SignalDelegator.h b/External/FEXCore/include/FEXCore/Core/SignalDelegator.h index 0575ae090..e0225e714 100644 --- a/External/FEXCore/include/FEXCore/Core/SignalDelegator.h +++ b/External/FEXCore/include/FEXCore/Core/SignalDelegator.h @@ -30,6 +30,8 @@ namespace Core { class SignalDelegator { public: + virtual ~SignalDelegator() = default; + /** * @brief Registers an emulated thread's object to a TLS object * diff --git a/Source/Tests/LinuxSyscalls/SignalDelegator.h b/Source/Tests/LinuxSyscalls/SignalDelegator.h index 854b4df79..a7b0be438 100644 --- a/Source/Tests/LinuxSyscalls/SignalDelegator.h +++ b/Source/Tests/LinuxSyscalls/SignalDelegator.h @@ -30,7 +30,7 @@ namespace FEX::HLE { // Returns true if the host handled the signal // Arguments are the same as sigaction handler SignalDelegator(); - virtual ~SignalDelegator(); + ~SignalDelegator() override; /** * @brief Registers an emulated thread's object to a TLS object