From b80f05dd864cddbcb88cf94ccc7caabdc97cdf60 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Sun, 8 Sep 2024 20:13:14 -0700 Subject: [PATCH] Seccomp/BPFEmitter: Reorder check to avoid integer overflow warning --- .../LinuxEmulation/LinuxSyscalls/Seccomp/BPFEmitter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Tools/LinuxEmulation/LinuxSyscalls/Seccomp/BPFEmitter.cpp b/Source/Tools/LinuxEmulation/LinuxSyscalls/Seccomp/BPFEmitter.cpp index 75258a2f5..883cc593d 100644 --- a/Source/Tools/LinuxEmulation/LinuxSyscalls/Seccomp/BPFEmitter.cpp +++ b/Source/Tools/LinuxEmulation/LinuxSyscalls/Seccomp/BPFEmitter.cpp @@ -307,10 +307,6 @@ uint64_t BPFEmitter::HandleEmission(uint32_t flags, const sock_fprog* prog) { HadError = PredFunc(Result); - if constexpr (CalculateSize) { - CalculatedSize += Result; - } - if (HadError) { if constexpr (!CalculateSize) { // Had error, early return and free the memory. @@ -318,6 +314,10 @@ uint64_t BPFEmitter::HandleEmission(uint32_t flags, const sock_fprog* prog) { } return Result; } + + if constexpr (CalculateSize) { + CalculatedSize += Result; + } } if constexpr (CalculateSize) {