diff --git a/External/FEXCore/Source/Common/JitSymbols.cpp b/External/FEXCore/Source/Common/JitSymbols.cpp index fd3037c47..e85145922 100644 --- a/External/FEXCore/Source/Common/JitSymbols.cpp +++ b/External/FEXCore/Source/Common/JitSymbols.cpp @@ -1,66 +1,53 @@ #include "Common/JitSymbols.h" #include -#include #include -namespace FEXCore { - JITSymbols::JITSymbols() { - std::stringstream PerfMap; - PerfMap << "/tmp/perf-" << getpid() << ".map"; +#include - fp = fopen(PerfMap.str().c_str(), "wb"); +namespace FEXCore { + JITSymbols::JITSymbols() : fp{nullptr, std::fclose} { + const auto PerfMap = fmt::format("/tmp/perf-{}.map", getpid()); + + fp.reset(fopen(PerfMap.c_str(), "wb")); if (fp) { // Disable buffering on this file - setvbuf(fp, nullptr, _IONBF, 0); + setvbuf(fp.get(), nullptr, _IONBF, 0); } } - JITSymbols::~JITSymbols() { - if (fp) { - fclose(fp); - } - } + JITSymbols::~JITSymbols() = default; - void JITSymbols::Register(void *HostAddr, uint64_t GuestAddr, uint32_t CodeSize) { + void JITSymbols::Register(const void *HostAddr, uint64_t GuestAddr, uint32_t CodeSize) { if (!fp) return; // Linux perf format is very straightforward // ` \n` - std::stringstream String; - String << std::hex << HostAddr << " " << CodeSize << " " << "JIT_0x" << GuestAddr << "_" << HostAddr << std::endl; - fwrite(String.str().c_str(), 1, String.str().size(), fp); + fmt::print(fp.get(), "{:x} {:x} JIT_0x{:x}_{:x}\n", HostAddr, CodeSize, GuestAddr, HostAddr); } - void JITSymbols::Register(void *HostAddr, uint32_t CodeSize, std::string const &Name) { + void JITSymbols::Register(const void *HostAddr, uint32_t CodeSize, std::string_view Name) { if (!fp) return; // Linux perf format is very straightforward // ` \n` - std::stringstream String; - String << std::hex << HostAddr << " " << CodeSize << " " << Name << "_" << HostAddr << std::endl; - fwrite(String.str().c_str(), 1, String.str().size(), fp); + fmt::print(fp.get(), "{:x} {:x} {}_{:x}\n", HostAddr, CodeSize, Name, HostAddr); } - void JITSymbols::RegisterNamedRegion(void *HostAddr, uint32_t CodeSize, std::string const &Name) { + void JITSymbols::RegisterNamedRegion(const void *HostAddr, uint32_t CodeSize, std::string_view Name) { if (!fp) return; // Linux perf format is very straightforward // ` \n` - std::stringstream String; - String << std::hex << HostAddr << " " << CodeSize << " " << Name << std::endl; - fwrite(String.str().c_str(), 1, String.str().size(), fp); + fmt::print(fp.get(), "{:x} {:x} {}\n", HostAddr, CodeSize, Name); } - void JITSymbols::RegisterJITSpace(void *HostAddr, uint32_t CodeSize) { + void JITSymbols::RegisterJITSpace(const void *HostAddr, uint32_t CodeSize) { if (!fp) return; // Linux perf format is very straightforward // ` \n` - std::stringstream String; - String << std::hex << HostAddr << " " << CodeSize << " FEXJIT" << std::endl; - fwrite(String.str().c_str(), 1, String.str().size(), fp); + fmt::print(fp.get(), "{:x} {:x} FEXJIT\n", HostAddr, CodeSize); } -} - +} // namespace FEXCore diff --git a/External/FEXCore/Source/Common/JitSymbols.h b/External/FEXCore/Source/Common/JitSymbols.h index 52e120cda..afe394e28 100644 --- a/External/FEXCore/Source/Common/JitSymbols.h +++ b/External/FEXCore/Source/Common/JitSymbols.h @@ -1,19 +1,24 @@ #pragma once + #include #include -#include +#include +#include namespace FEXCore { class JITSymbols final { public: JITSymbols(); ~JITSymbols(); - void Register(void *HostAddr, uint64_t GuestAddr, uint32_t CodeSize); - void Register(void *HostAddr, uint32_t CodeSize, std::string const &Name); - void RegisterNamedRegion(void *HostAddr, uint32_t CodeSize, std::string const &Name); - void RegisterJITSpace(void *HostAddr, uint32_t CodeSize); + + void Register(const void *HostAddr, uint64_t GuestAddr, uint32_t CodeSize); + void Register(const void *HostAddr, uint32_t CodeSize, std::string_view Name); + void RegisterNamedRegion(const void *HostAddr, uint32_t CodeSize, std::string_view Name); + void RegisterJITSpace(const void *HostAddr, uint32_t CodeSize); private: - FILE* fp{}; + using FILEPtr = std::unique_ptr; + + FILEPtr fp; }; }