steam-frame/bearstonem--openmohaa-vr
1
0 Fork 0
mirror of https://github.com/bearstonem/openmohaa-vr.git synced 2026-10-23 11:00:26 +02:00
Code Issues Packages Projects Releases 2 Wiki Activity

Fix integer overflow in wait command that would cause infinite loop in stock scripts

Browse Source 
It was causing a rare infinite loop in anim/stand.scr where it waits for 9999999 if the actor is unarmed and medic
This commit is contained in:
smallmodel committed 2024-11-16 19:10:26 +01:00
1 parent 824cfd789c
commit b68bb4cee7
1 file changed
+7 -2
Download Patch File Download Diff File Expand all files Collapse all files
code/fgame/scriptthread.cpp
+7 -2
View File
@@ -2711,12 +2711,17 @@ void ScriptThread::EventDelayThrow(Event *ev)
void ScriptThread::EventWait(Event *ev)
{
Wait((int)roundf(ev->GetFloat(1) * 1000.0f));
float timeSeconds;
// Fixed in OPM
// Clamp to make sure to not overflow when converting to integer
timeSeconds = Q_clamp_float(ev->GetFloat(1), 0, 2000000);
Wait((int)roundf(timeSeconds * 1000));
}
void ScriptThread::EventWaitFrame(Event *ev)
{
Wait((int)roundf(level.frametime * 1000.0f));
Wait((int)roundf(level.frametime * 1000));
}
void ScriptThread::EventResume(Event *ev)