spoopyghosty0--frameport/tests/test_connection_auth.py

"""Logging in to the Frame (Reddit 2026-10-03: "Couldn't connect: no authentication methods available" even with the
right password). paramiko ends the key/agent attempt with a plain SSHException when this PC has no SSH keys; that must
not stop the password attempt, and the final error must say what to do."""
import paramiko
import pytest

from frameport.errors import explain
from frameport.frame import connection as C


class _Client:
    """Stands in for paramiko.SSHClient: `script` maps attempt kind -> exception (or None = success)."""
    script: dict = {}
    tried: list = []

    def load_host_keys(self, path):
        pass

    def set_missing_host_key_policy(self, policy):
        pass

    def close(self):
        pass

    def save_host_keys(self, path):
        pass

    def connect(self, pkey=None, password=None, allow_agent=False, look_for_keys=False, **kw):
        kind = "password" if password else "agent" if allow_agent else "app_key"
        _Client.tried.append(kind)
        exc = _Client.script.get(kind)
        if exc is not None:
            raise exc


@pytest.fixture
def fake_ssh(monkeypatch):
    monkeypatch.setattr(C.paramiko, "SSHClient", _Client)
    monkeypatch.setattr(C, "app_keys", lambda: ["key"])
    _Client.tried = []
    return _Client


NO_METHODS = paramiko.SSHException("No authentication methods available")


def test_no_ssh_keys_on_the_pc_still_tries_the_password(fake_ssh, monkeypatch):
    fake_ssh.script = {"app_key": paramiko.AuthenticationException("Authentication failed."), "agent": NO_METHODS,
                       "password": paramiko.AuthenticationException("Authentication failed.")}
    frame = C.Frame(C.FrameTarget("10.0.0.2"), password="secret")
    with pytest.raises(C.FrameNotPaired) as err:
        frame.connect()
    assert fake_ssh.tried == ["app_key", "agent", "password"]
    assert err.value.tried_password and "password was refused" in str(err.value)
    assert "refused that password" in explain(err.value)


def test_unpaired_frame_without_password_explains_the_setup(fake_ssh):
    fake_ssh.script = {"app_key": paramiko.AuthenticationException("Authentication failed."), "agent": NO_METHODS}
    with pytest.raises(C.FrameNotPaired) as err:
        C.Frame(C.FrameTarget("10.0.0.2")).connect()
    assert "authentication failed" in str(err.value).lower()  # app.connect's devkit fallback looks for this
    assert "Start setup" in explain(err.value) and "isn't set up" in explain(err.value)
    assert explain(NO_METHODS).startswith("This Frame isn't set up")


def test_network_errors_still_end_the_attempts(fake_ssh):
    fake_ssh.script = {"app_key": paramiko.SSHException("Error reading SSH protocol banner")}
    with pytest.raises(paramiko.SSHException, match="banner"):
        C.Frame(C.FrameTarget("10.0.0.2"), password="x").connect()
    assert fake_ssh.tried == ["app_key"]


def test_upload_resumes_after_a_transient_error(tmp_path, monkeypatch):
    from frameport.frame.connection import Frame, FrameTarget

    f = Frame(FrameTarget("h"))
    calls = []

    def flaky(local, remote, progress, resume, mkdir):
        calls.append(1)
        if len(calls) == 1:
            raise OSError(22, "Invalid argument")
    monkeypatch.setattr(f, "_put", flaky)
    monkeypatch.setattr(f, "alive", lambda: True)
    monkeypatch.setattr("frameport.frame.connection.time.sleep", lambda s: None)
    f.put(tmp_path / "x.bin", "/r/x.bin")
    assert len(calls) == 2


def test_framport_on_the_frame_targets_itself(tmp_path, monkeypatch):
    from frameport.frame import connection, local

    monkeypatch.setattr(local, "on_frame", lambda: True)
    monkeypatch.setattr(local.Path, "home", lambda: tmp_path)
    targets = connection.saved_targets()
    assert targets and targets[0].host == "127.0.0.1" and targets[0].name == local.LOCAL_NAME
    keys = (tmp_path / ".ssh/authorized_keys").read_text()
    assert connection.app_public_key().split()[1] in keys
    assert not local.authorize_self(connection.app_public_key())  # once
    monkeypatch.setattr(local, "on_frame", lambda: False)
    assert connection.saved_targets()[0].host == "127.0.0.1"  # remembered like any Frame


def test_app_data_on_the_frame_stays_out_of_the_agents_folder(monkeypatch, tmp_path):
    from frameport.core import paths
    from frameport.frame import local

    monkeypatch.delenv("FRAMEPORT_HOME", raising=False)
    monkeypatch.setenv("XDG_DATA_HOME", str(tmp_path))
    monkeypatch.setattr(local, "on_frame", lambda: True)
    assert paths.user_data_dir() == tmp_path / "frameport-app"  # the agent owns (and purges) .../frameport
    monkeypatch.setattr(local, "on_frame", lambda: False)
    assert paths.user_data_dir() == tmp_path / "frameport"


def test_changed_host_key_is_its_own_error_and_can_be_trusted(fake_ssh, monkeypatch, tmp_path):
    """Reddit 2026-10-12: "Host key for server '<ip>' does not match" after SteamOS was set up again. FramePort says
    what happened (not "can't reach"), and forgetting the saved key lets the next connection keep the new one."""
    from cryptography.hazmat.primitives import serialization
    from cryptography.hazmat.primitives.asymmetric import ed25519

    def key():
        raw = ed25519.Ed25519PrivateKey.generate().private_bytes(
            serialization.Encoding.PEM, serialization.PrivateFormat.OpenSSH, serialization.NoEncryption())
        path = tmp_path / f"k{len(list(tmp_path.iterdir()))}"
        path.write_bytes(raw)
        return paramiko.Ed25519Key.from_private_key_file(str(path))

    got, expected = key(), key()
    fake_ssh.script = {"app_key": paramiko.BadHostKeyException("10.0.0.2", got, expected)}
    monkeypatch.setattr(C.Frame, "relocate", lambda self: None)
    with pytest.raises(C.HostKeyChanged) as err:
        C.Frame(C.FrameTarget("10.0.0.2")).connect()
    assert fake_ssh.tried == ["app_key"] and err.value.host == "10.0.0.2"
    from frameport.errors import is_connection_error

    assert not is_connection_error(err.value) and "Trust the new key" in explain(err.value)
    known = tmp_path / "ssh"
    known.mkdir()
    monkeypatch.setattr(C, "ssh_dir", lambda: known)
    keys = paramiko.HostKeys()
    keys.add("10.0.0.2", expected.get_name(), expected)
    keys.add("10.0.0.9", expected.get_name(), expected)
    keys.save(str(known / "known_hosts"))
    assert C.forget_host_key("10.0.0.2") is True and C.forget_host_key("10.0.0.2") is False
    left = paramiko.HostKeys(str(known / "known_hosts"))
    assert "10.0.0.2" not in left and "10.0.0.9" in left