steam-frame/FEX-Emu--FEX
1
0 Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2026-10-21 00:01:10 +02:00
Code Issues Packages Projects Releases 67 Wiki Activity

Fixes RCLSE pass generating bad IR

Browse Source 
Don't do DCE inside the pass, let the DCE pass actually handle this.
This was causing later passes to crash
This commit is contained in:
Ryan Houdek committed 2020-03-16 13:13:17 -07:00
1 parent 3bb154b7f0
commit ef63f5f30f
1 file changed
-12
Download Patch File Download Diff File Expand all files Collapse all files
External/FEXCore/Source/Interface/IR/Passes/DeadContextStoreElimination.cpp
Vendored
-12
View File
@@ -392,8 +392,6 @@ bool RCLSE::RedundantStoreLoadElimination(FEXCore::IR::OpDispatchBuilder *Disp)
Disp->ReplaceAllUsesWithInclusive(CodeNode, LastNode, CodeBegin, CodeLast);
RecordAccess(Info, Op->Offset, Op->Size, ACCESS_READ, LastNode);
}
if (CodeNode->GetUses() == 0)
Disp->Remove(CodeNode);
Changed = true;
}
else if (LastAccess == ACCESS_READ &&
@@ -401,9 +399,6 @@ bool RCLSE::RedundantStoreLoadElimination(FEXCore::IR::OpDispatchBuilder *Disp)
// Did we read and then read again?
Disp->ReplaceAllUsesWithInclusive(CodeNode, LastNode, CodeBegin, CodeLast);
RecordAccess(Info, Op->Offset, Op->Size, ACCESS_READ, LastNode);
if (CodeNode->GetUses() == 0)
Disp->Remove(CodeNode);
Changed = true;
}
}
@@ -411,12 +406,10 @@ bool RCLSE::RedundantStoreLoadElimination(FEXCore::IR::OpDispatchBuilder *Disp)
auto Op = IROp->CW<IR::IROp_StoreFlag>();
auto Info = FindMemberInfo(&LocalInfo, offsetof(FEXCore::Core::CPUState, flags[0]) + Op->Flag, 1);
LastAccessType LastAccess = Info->Accessed;
OrderedNode *LastNode2 = Info->Node2;
if (LastAccess == ACCESS_WRITE) {
// If we last wrote to this flag then we can eliminate the last store
// LastNode2 = node doing the write
Disp->Remove(LastNode2);
RecordAccess(&LocalInfo, offsetof(FEXCore::Core::CPUState, flags[0]) + Op->Flag, 1, ACCESS_WRITE, Op->Header.Args[0].GetNode(ListBegin), CodeNode);
Changed = true;
}
@@ -434,8 +427,6 @@ bool RCLSE::RedundantStoreLoadElimination(FEXCore::IR::OpDispatchBuilder *Disp)
Disp->SetWriteCursor(CodeNode);
auto Res = Disp->_Bfe(1, 0, LastNode);
Disp->ReplaceAllUsesWithInclusive(CodeNode, Res, CodeBegin, CodeLast);
if (CodeNode->GetUses() == 0)
Disp->Remove(CodeNode);
RecordAccess(Info, offsetof(FEXCore::Core::CPUState, flags[0]) + Op->Flag, 1, ACCESS_READ, Res);
Changed = true;
}
@@ -443,9 +434,6 @@ bool RCLSE::RedundantStoreLoadElimination(FEXCore::IR::OpDispatchBuilder *Disp)
Disp->SetWriteCursor(CodeNode);
Disp->ReplaceAllUsesWithInclusive(CodeNode, LastNode, CodeBegin, CodeLast);
RecordAccess(Info, offsetof(FEXCore::Core::CPUState, flags[0]) + Op->Flag, 1, ACCESS_READ, CodeNode);
if (CodeNode->GetUses() == 0)
Disp->Remove(CodeNode);
Changed = true;
}
}