st/oxr: Rename and document common swapchain creation function [NFC]

This commit is contained in:
Jakob Bornecrantz committed 2023-04-18 14:21:10 +01:00
1 parent 9055b9d2ec
commit b49cd74114
6 files changed
+23 -12

No files matched your search

+15 -4
View File
@@ -803,11 +803,22 @@ oxr_swapchain_to_openxr(struct oxr_swapchain *sc)
return XRT_CAST_PTR_TO_OXR_HANDLE(XrSwapchain, sc);
}
/*!
* Shared create function for swapchains, called by grahpics API specific
* implementations list below. Does most init, but not @ref xrt_swapchain
* allocation and other API specific things.
*
* @param log Logger set with the current OpenXR function call context.
* @param sess OpenXR session
* @param createInfo Creation info.
* @param sc Swapchain.
* @param[out] out_swapchain Return of the allocated swapchain.
*/
XrResult
oxr_create_swapchain(struct oxr_logger * /*log*/,
struct oxr_session *sess,
const XrSwapchainCreateInfo * /*createInfo*/,
struct oxr_swapchain **out_swapchain);
oxr_swapchain_common_create(struct oxr_logger *log,
struct oxr_session *sess,
const XrSwapchainCreateInfo *createInfo,
struct oxr_swapchain **out_swapchain);
/*
+4 -4
View File
@@ -219,10 +219,10 @@ destroy_handle(struct oxr_logger *log, struct oxr_handle_base *hb)
*/
XrResult
oxr_create_swapchain(struct oxr_logger *log,
struct oxr_session *sess,
const XrSwapchainCreateInfo *createInfo,
struct oxr_swapchain **out_swapchain)
oxr_swapchain_common_create(struct oxr_logger *log,
struct oxr_session *sess,
const XrSwapchainCreateInfo *createInfo,
struct oxr_swapchain **out_swapchain)
{
xrt_result_t xret = XRT_SUCCESS;
@@ -43,7 +43,7 @@ oxr_swapchain_d3d11_create(struct oxr_logger *log,
struct oxr_swapchain *sc;
XrResult ret;
ret = oxr_create_swapchain(log, sess, createInfo, &sc);
ret = oxr_swapchain_common_create(log, sess, createInfo, &sc);
if (ret != XR_SUCCESS) {
return ret;
}
@@ -51,7 +51,7 @@ oxr_swapchain_d3d12_create(struct oxr_logger *log,
XR_SWAPCHAIN_USAGE_UNORDERED_ACCESS_BIT,
XR_SWAPCHAIN_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT);
ret = oxr_create_swapchain(log, sess, createInfo, &sc);
ret = oxr_swapchain_common_create(log, sess, createInfo, &sc);
if (ret != XR_SUCCESS) {
return ret;
}
@@ -88,7 +88,7 @@ oxr_swapchain_gl_create(struct oxr_logger *log,
struct oxr_swapchain *sc;
XrResult ret;
ret = oxr_create_swapchain(log, sess, createInfo, &sc);
ret = oxr_swapchain_common_create(log, sess, createInfo, &sc);
if (ret != XR_SUCCESS) {
return ret;
}
@@ -41,7 +41,7 @@ oxr_swapchain_vk_create(struct oxr_logger *log,
struct oxr_swapchain *sc;
XrResult ret;
ret = oxr_create_swapchain(log, sess, createInfo, &sc);
ret = oxr_swapchain_common_create(log, sess, createInfo, &sc);
if (ret != XR_SUCCESS) {
return ret;
}