Merge pull request #242 from saphid/release/v0.4.34

Prepare Frame Control v0.4.34

app/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "frame-control",
-  "version": "0.4.33",
+  "version": "0.4.34",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "frame-control",
-      "version": "0.4.33",
+      "version": "0.4.34",
       "license": "MIT",
       "devDependencies": {
         "electron": "^44.4.5",

app/package.json

@@ -1,7 +1,7 @@
 {
   "name": "frame-control",
   "productName": "Frame Control",
-  "version": "0.4.33",
+  "version": "0.4.34",
   "description": "Desktop app for managing a Valve Steam Frame over SSH",
   "private": true,
   "main": "main.js",

docs/current-support-matrix.md

@@ -1,6 +1,6 @@
 # What we have tested
 
-Current for Frame Control **v0.4.33**, 25 October 2026. “Real Frame + physical PC” means an actual headset and a non-virtual computer. “VM only” means a Windows virtual machine, sometimes connected to the real Frame. A CI test or a simulated device is **not** a physical hardware test. The date/version column is the last relevant check, not a promise that every new release was retested on that platform. See each link for the exact procedure and limits.
+Current for Frame Control **v0.4.34**, 25 October 2026. “Real Frame + physical PC” means an actual headset and a non-virtual computer. “VM only” means a Windows virtual machine, sometimes connected to the real Frame. A CI test or a simulated device is **not** a physical hardware test. The date/version column is the last relevant check, not a promise that every new release was retested on that platform. See each link for the exact procedure and limits.
 
 | Feature | Real Frame + physical PC tested | VM only | Untested or limited | Last check and proof |
 |---|---|---|---|---|
@@ -24,6 +24,6 @@ Current for Frame Control **v0.4.33**, 25 October 2026. “Real Frame + physical
 | Local Frame Control extensions | Example panel displayed live Frame status in a browser preview; the real Frame served a read-only example in the experimental headset panel | No | No wearer-visible extension view; third-party extensions and physical Windows/macOS extension folders untested | 25 Oct, v0.4.29: [PR #194](https://github.com/saphid/frame-control/pull/194), [PR #201](https://github.com/saphid/frame-control/pull/201), [extension guide](extensions.md) |
 | Experimental Frame Control SteamVR panel | Real Frame OS 0.5.6 installed its user service, registered an overlay, served authenticated live status and a read-only extension, saved a screenshot and short MP4, and removed owned resources | No | Headset was unworn in standby: overlay reported `not_visible`, stereo capture was dark; wearer-visible pixels and controller input are unverified. The new large read-only status screen has browser layout and packaging checks only | 25 Oct, v0.4.29 device check and v0.4.31 status screen: [PR #198](https://github.com/saphid/frame-control/pull/198), [PR #201](https://github.com/saphid/frame-control/pull/201), [PR #220](https://github.com/saphid/frame-control/pull/220), [panel guide](headset-app.md) |
 | Experimental Decky Loader manager | Real Frame OS 0.5.6 ARM64 user-service install, status, update and remove completed; seven official-store plugin backends loaded, and ProtonDB Badges completed managed store install/update/remove | No | v0.4.33 shared transaction lock and stopped-loader plugin removal have Linux and CI tests, but no live recovery test on the Frame. Plugin pages, settings, routes, toasts and controller input in VR remain unverified; some plugins need root, x86_64 binaries or Deck-specific hardware | 25 Oct, v0.4.31 hardware and v0.4.33 tests: [PR #208](https://github.com/saphid/frame-control/pull/208), [PR #230](https://github.com/saphid/frame-control/pull/230), [PR #234](https://github.com/saphid/frame-control/pull/234), [compatibility table](decky-frame.md) |
-| Experimental Framey VR plugin panels and store | No live real-Frame panel test | No | ProtonDB Badges settings rendered and sent a setting call in local Chromium. Fake Frame tests cover setting read/write through update and reinstall; page tests cover the official JSX runtime, stale job recovery and an author sample bundle. The sample is not published in the store. Wearer-visible pixels, controller input and live settings persistence remain unverified | 25 Oct, v0.4.32–0.4.33: [#223](https://github.com/saphid/frame-control/pull/223), [#224](https://github.com/saphid/frame-control/pull/224), [#225](https://github.com/saphid/frame-control/pull/225), [#226](https://github.com/saphid/frame-control/pull/226), [#227](https://github.com/saphid/frame-control/pull/227), [#229](https://github.com/saphid/frame-control/pull/229), [#231](https://github.com/saphid/frame-control/pull/231), [#232](https://github.com/saphid/frame-control/pull/232), [#233](https://github.com/saphid/frame-control/pull/233), [browser/fake Frame evidence](evidence/framey-browser-2026-10-25.md), [guide](framey-loader.md) |
+| Experimental Framey VR plugin panels and store | No live real-Frame panel test | No | ProtonDB Badges settings rendered and sent a setting call in local Chromium. Fake Frame tests cover setting read/write through update and reinstall and install/remove two pinned official API v2 archives. Page tests cover the official JSX runtime, disabled controls, text fields, sliders, grouped dropdowns and an author sample bundle. The sample is not published in the store. The 11-archive manifest audit found only ProtonDB Badges API v2 in that set; a hash match and fake Frame install do not prove VR use. Wearer-visible pixels, controller input and live settings persistence remain unverified | 25 Oct, v0.4.32–0.4.34: [#223](https://github.com/saphid/frame-control/pull/223), [#224](https://github.com/saphid/frame-control/pull/224), [#225](https://github.com/saphid/frame-control/pull/225), [#226](https://github.com/saphid/frame-control/pull/226), [#227](https://github.com/saphid/frame-control/pull/227), [#229](https://github.com/saphid/frame-control/pull/229), [#231](https://github.com/saphid/frame-control/pull/231), [#232](https://github.com/saphid/frame-control/pull/232), [#233](https://github.com/saphid/frame-control/pull/233), [#236](https://github.com/saphid/frame-control/pull/236), [#237](https://github.com/saphid/frame-control/pull/237), [#238](https://github.com/saphid/frame-control/pull/238), [#239](https://github.com/saphid/frame-control/pull/239), [#240](https://github.com/saphid/frame-control/pull/240), [#241](https://github.com/saphid/frame-control/pull/241), [browser/fake Frame evidence](evidence/framey-browser-2026-10-25.md), [guide](framey-loader.md) |
 
 Release notes must preserve these limits until a newer recorded check changes them. When a feature is retested, add its date, exact app/Frame version, host type and proof here. The older [v0.3.1 matrix](support-matrix.html) is a historical snapshot and does not describe current coverage.

docs/frame-plugin-author.md

@@ -35,6 +35,12 @@ remain unavailable. Wearer-visible use is not yet verified.
 The [settings sample](../examples/framey-settings/README.md) shows an official
 Decky JSX build, backend persistence, a toggle and a local toast. Framey offers
 only official-store-owned plugins in its VR panel.
+For persistent backend settings, use Decky's `decky.decky_SETTINGS_DIR` rather
+than assuming an environment variable or Steam Deck home path. Validate stored
+types when reading, write through a temporary file before replacing the old
+file, and give the panel a safe default if settings are missing or damaged.
+Removing a managed plugin leaves its Decky settings behind; document how users
+can reset data your plugin owns.
 
 To test safely, use a separate Frame Control managed Decky install, verify the
 ZIP digest from the official store, install one plugin at a time, and inspect
@@ -51,7 +57,8 @@ none of these frontend controls has passed a worn-headset check yet.
 | --- | --- | --- |
 | `definePlugin` with `content`, `titleView` | Renders a React panel and optional title | Local browser with ProtonDB Badges; host unit test |
 | Official `@decky/rollup` JSX (`SP_JSX.jsx`, `jsxs`, `Fragment`) | Creates React elements in the isolated panel | Sample bundle smoke test; host unit test |
-| `PanelSection`, rows, buttons, toggles, dropdowns | Local touch-sized controls | Local browser and host unit test |
+| `PanelSection`, rows, buttons, toggles, dropdowns | Local touch-sized controls; disabled controls stay inert during a backend call | Local browser and host unit test |
+| `TextField`, `SliderField`, grouped `Dropdown` options | Native text, range and select controls in the panel; disabled state, numeric slider callback and basic input types | Host unit test; worn VR use unverified |
 | Optional `settings`, `frameyQuickActions` | Separate settings tab; up to eight actions with result text | Host unit test; these fields are Framey additions |
 | `serverAPI.call` / `callable` | Calls only that plugin's Decky Python backend via the headset service | Fake Frame e2e for setting read/write across CEF calls, update, and reinstall; host unit test. Real Decky persistence remains unverified. |
 | `toaster.toast` | Visible toast inside the plugin panel; `dismiss` and optional `onClick` | Host unit test; no Steam system notification |

docs/framey-loader.md

@@ -19,7 +19,8 @@ panel or Decky backend keeps plugin folders until each is removed separately.
 
 Frame Control's existing official-store manager downloads a published ZIP from
 Decky's content-addressed CDN, verifies its store SHA-256 hash and manifest,
-rejects unsafe ZIP members and root plugins, and swaps one managed plugin
+rejects unsafe ZIP members, path collisions, special files and root plugins,
+and swaps one managed plugin
 folder with rollback on failure. It rejects non-ARM64 ELF and Windows binaries.
 The Decky user service restarts after a file change. Framey's panel host accepts
 only API v2 bundles with `dist/index.js`; other installed plugins remain
@@ -37,7 +38,8 @@ Decky websocket, because Decky allows only one frontend connection. The iframe
 does not receive Frame Control's UI key. React and ReactDOM are bundled for
 offline use under their MIT licenses in `ui/vendor`.
 
-The host currently supplies sections, rows, buttons, toggles, dropdowns,
+The host currently supplies sections, rows, buttons, toggles, text fields,
+sliders, grouped dropdowns,
 scroll containers, a modal, locale information, local panel routes and toasts,
 and backend calls for the plugin that owns the panel. Steam library/store page
 patches, global Steam UI components, file pickers, and privileged root methods
@@ -53,6 +55,10 @@ live Decky settings persistence, or badges on Steam game pages. The last item
 has no supported injection target in the Frame Control panel.
 The [browser and fake Frame evidence](evidence/framey-browser-2026-10-25.md)
 records exactly what was exercised.
+Fake Frame CI also installs and removes pinned official ProtonDB Badges 1.3.4
+and Steam Status 1.2.3 archives, checks their API v2 manifests and frontend
+bytes, and verifies they can be packed as Framey panels. It does not execute
+their actual backend code or prove their frontend controls work in VR.
 
 The fake Frame integration test now writes a Decky setting through Framey's
 scoped backend endpoint, reads it in a new CEF request, updates the plugin,

examples/framey-settings/README.md

@@ -4,7 +4,9 @@ This is a small Decky API v2 plugin for authors. Its panel uses the official
 `@decky/api`, `@decky/ui`, and `@decky/rollup` packages. A toggle calls a Python
 backend method, stores one boolean under `decky.decky_SETTINGS_DIR`,
 and reads it back when the panel opens. The backend rejects other keys and
-values. The frontend also shows a local toast after a successful save.
+values. The frontend also shows a local toast after a successful save. A
+missing, damaged, or old non-boolean value reads as the caller's default;
+the next save atomically replaces the sample's settings file.
 
 ## Build
 
@@ -33,5 +35,5 @@ has passed for this sample yet.
 
 The plugin needs no root access or system changes. Its settings remain after
 the managed plugin folder is removed, following Decky's settings behavior.
-For a production plugin, add migration and recovery handling for damaged
-settings files, and test every UI path in a worn headset.
+For a production plugin, add explicit migrations for every supported schema,
+explain how users can reset settings, and test every UI path in a worn headset.

examples/framey-settings/main.py

@@ -16,10 +16,11 @@ class Plugin:
         if key != 'enabled':
             raise ValueError('Unknown setting')
         try:
-            stored = json.loads(settings_file().read_text())
-        except FileNotFoundError:
+            stored = json.loads(settings_file().read_text(encoding='utf-8'))
+        except (FileNotFoundError, json.JSONDecodeError, UnicodeDecodeError):
             return default
-        return stored.get(key, default)
+        value = stored.get(key) if isinstance(stored, dict) else None
+        return value if type(value) is bool else default
 
     async def set_setting(self, key: str, value: bool):
         if key != 'enabled' or type(value) is not bool:

tests/e2e/test_framey.py

@@ -10,6 +10,7 @@ import threading
 import zipfile
 
 from harness import FrameTestCase, ROOT, Server, api, finished, ok, require, ssh
+from framey_official import PLUGINS as OFFICIAL_PLUGINS, archive as official_archive
 
 require()  # Skip the module outside the disposable fake Frame, like its peers.
 
@@ -26,6 +27,10 @@ def archive(version):
 
 ARTIFACTS = {hashlib.sha256(a).hexdigest(): a for a in (archive('1.0.0'), archive('1.1.0'))}
 HASHES = list(ARTIFACTS)
+for plugin in OFFICIAL_PLUGINS:
+    data = official_archive(plugin)
+    assert hashlib.sha256(data).hexdigest() == plugin['sha256']
+    ARTIFACTS[plugin['sha256']] = data
 
 
 class StoreFixture(BaseHTTPRequestHandler):
@@ -35,10 +40,15 @@ class StoreFixture(BaseHTTPRequestHandler):
 
     def do_GET(self):
         if self.path == '/plugins':
-            body = json.dumps([{'id':123,'name':'Sample Panel','author':'Fixture',
+            records = [{'id':999,'name':'Sample Panel','author':'Fixture',
                                 'description':'A harmless panel','tags':[],
                                 'versions':[{'name':['1.0.0','1.1.0'][self.release],
-                                             'hash':HASHES[self.release]}]}]).encode()
+                                             'hash':HASHES[self.release]}]}]
+            records.extend({'id':plugin['id'], 'name':plugin['name'], 'author':'Official Decky store',
+                            'description':'Pinned official archive', 'tags':[],
+                            'versions':[{'name':plugin['version'], 'hash':plugin['sha256']}]}
+                           for plugin in OFFICIAL_PLUGINS)
+            body = json.dumps(records).encode()
             content_type = 'application/json'
         elif self.path.startswith('/versions/') and self.path.endswith('.zip'):
             body = ARTIFACTS.get(self.path.split('/')[-1][:-4])
@@ -93,41 +103,66 @@ u=h/'.config/systemd/user/frame-control-decky.service'; u.parent.mkdir(parents=T
         self.assertEqual(status, 403)
         catalogue = ok('GET', '/api/decky/store')['plugins']
         self.assertEqual((catalogue[0]['version'], catalogue[0]['sha256']), ('1.0.0', HASHES[0]))
-        status, _, _ = api('POST', '/api/decky/plugin', {'action':'install','id':123})
+        status, _, _ = api('POST', '/api/decky/plugin', {'action':'install','id':999})
         self.assertEqual(status, 400)  # Third-party code needs explicit acknowledgement.
         job = finished(ok('POST', '/api/decky/plugin',
-                          {'action':'install','id':123,'acknowledged':True}))
+                          {'action':'install','id':999,'acknowledged':True}))
         self.assertFalse(job.get('error'), job)
         self.assertEqual(ok('GET', '/api/decky')['plugins'][0]['version'], '1.0.0')
         self.assertIn('Sample 1.0.0', ssh('cat ~/.local/share/frame-control/decky/plugins/sample-panel/dist/index.js'))
-        status, _, _ = api('POST', '/api/framey/method', {'id':123,'method':'get_setting','args':[]},
+        status, _, _ = api('POST', '/api/framey/method', {'id':999,'method':'get_setting','args':[]},
                            headers={'X-Frame-UI':''})
         self.assertEqual(status, 403)
-        status, _, _ = api('POST', '/api/framey/method', {'id':123,'method':'x;alert(1)','args':[]})
+        status, _, _ = api('POST', '/api/framey/method', {'id':999,'method':'x;alert(1)','args':[]})
         self.assertEqual(status, 400)
         self.assertEqual(ok('POST', '/api/framey/method',
-                            {'id':123,'method':'get_setting','args':['theme','dark']})['result'], 'dark')
+                            {'id':999,'method':'get_setting','args':['theme','dark']})['result'], 'dark')
         self.assertTrue(ok('POST', '/api/framey/method',
-                           {'id':123,'method':'set_setting','args':['theme','light']})['result'])
+                           {'id':999,'method':'set_setting','args':['theme','light']})['result'])
         self.assertEqual(ok('POST', '/api/framey/method',
-                            {'id':123,'method':'get_setting','args':['theme','dark']})['result'], 'light')
+                            {'id':999,'method':'get_setting','args':['theme','dark']})['result'], 'light')
+
         StoreFixture.release = 1
         job = finished(ok('POST', '/api/decky/plugin',
-                          {'action':'update','id':123,'acknowledged':True}))
+                          {'action':'update','id':999,'acknowledged':True}))
         self.assertFalse(job.get('error'), job)
         self.assertEqual(ok('GET', '/api/decky')['plugins'][0]['version'], '1.1.0')
         self.assertEqual(ok('POST', '/api/framey/method',
-                            {'id':123,'method':'get_setting','args':['theme','dark']})['result'], 'light')
+                            {'id':999,'method':'get_setting','args':['theme','dark']})['result'], 'light')
         job = finished(ok('POST', '/api/decky/plugin',
-                          {'action':'remove','id':123,'acknowledged':True}))
+                          {'action':'remove','id':999,'acknowledged':True}))
         self.assertFalse(job.get('error'), job)
         self.assertEqual(ok('GET', '/api/decky')['plugins'], [])
         self.assertEqual(ssh('test -e ~/.local/share/frame-control/decky/plugins/sample-panel && echo yes || echo no').strip(), 'no')
         status, _, _ = api('POST', '/api/framey/method',
-                           {'id':123,'method':'get_setting','args':['theme','dark']})
+                           {'id':999,'method':'get_setting','args':['theme','dark']})
         self.assertEqual(status, 400)  # No method calls while the plugin is removed.
         job = finished(ok('POST', '/api/decky/plugin',
-                          {'action':'install','id':123,'acknowledged':True}))
+                          {'action':'install','id':999,'acknowledged':True}))
         self.assertFalse(job.get('error'), job)
         self.assertEqual(ok('POST', '/api/framey/method',
-                            {'id':123,'method':'get_setting','args':['theme','dark']})['result'], 'light')
+                            {'id':999,'method':'get_setting','args':['theme','dark']})['result'], 'light')
+
+    def test_two_pinned_official_api_v2_plugins_install_and_remove(self):
+        self.backend()
+        catalog = {plugin['id']:plugin for plugin in ok('GET', '/api/decky/store')['plugins']}
+        for plugin in OFFICIAL_PLUGINS:
+            with self.subTest(plugin=plugin['name']):
+                self.assertEqual(catalog[plugin['id']]['sha256'], plugin['sha256'])
+                job = finished(ok('POST', '/api/decky/plugin',
+                                  {'action':'install','id':plugin['id'],'acknowledged':True}))
+                self.assertFalse(job.get('error'), job)
+                found = [item for item in ok('GET', '/api/decky')['plugins']
+                         if item['storeId'] == plugin['id']]
+                self.assertEqual(len(found), 1)
+                self.assertEqual(found[0]['version'], plugin['version'])
+                installed = f"~/.local/share/frame-control/decky/plugins/{plugin['folder']}"
+                with zipfile.ZipFile(io.BytesIO(official_archive(plugin))) as bundle:
+                    expected = hashlib.sha256(bundle.read(plugin['folder']+'/dist/index.js')).hexdigest()
+                self.assertEqual(ssh(f'sha256sum {installed}/dist/index.js').split()[0], expected)
+                self.assertEqual(json.loads(ssh(f'cat {installed}/plugin.json'))['api_version'], 2)
+                job = finished(ok('POST', '/api/decky/plugin',
+                                  {'action':'remove','id':plugin['id'],'acknowledged':True}))
+                self.assertFalse(job.get('error'), job)
+                self.assertFalse(any(item['storeId'] == plugin['id']
+                                     for item in ok('GET', '/api/decky')['plugins']))

tests/fixtures/framey-official/README.md

@@ -0,0 +1,18 @@
+# Pinned Decky store test archives
+
+These are unmodified ZIPs downloaded from the official Decky store CDN on
+2026-10-25. Each ZIP includes its upstream `LICENSE`. They are test data, not
+plugins shipped or installed by Frame Control. The fake Frame tests serve them
+from a local fixture so CI does not depend on the store being online.
+
+| File | Official plugin | Version | Store SHA-256 |
+| --- | --- | --- | --- |
+| `14.zip` | ProtonDB Badges | 1.3.4 | `90a3453ac02709cad64096e7539fd8141fa56f99ae3441fc24a4990dc9684358` |
+| `123.zip` | Steam Status | 1.2.3 | `9053308e04a74f44745b45b9f4f50af3673348d367e7b14bacc5677de707ac4e` |
+
+The matching source projects are
+[ProtonDB Badges](https://github.com/bschelst/protondb-decky) and
+[Steam Status](https://github.com/bschelst/steamstatus-decky).
+The test verifies the ZIP digest, archive policy, API v2 manifest, installed
+frontend bytes, managed store receipt, and removal. It does **not** run their
+Python backends or prove their JavaScript panels render in the VR shell.

tests/framey_official.py

@@ -0,0 +1,15 @@
+"""Pinned official Decky store archives used only in disposable test fixtures."""
+from pathlib import Path
+
+
+ROOT = Path(__file__).parent / 'fixtures/framey-official'
+PLUGINS = (
+    {'id': 14, 'name': 'ProtonDB Badges', 'version': '1.3.4',
+     'folder': 'protondb-decky', 'sha256': '90a3453ac02709cad64096e7539fd8141fa56f99ae3441fc24a4990dc9684358'},
+    {'id': 123, 'name': 'Steam Status', 'version': '1.2.3',
+     'folder': 'steamstatus-decky', 'sha256': '9053308e04a74f44745b45b9f4f50af3673348d367e7b14bacc5677de707ac4e'},
+)
+
+
+def archive(plugin):
+    return (ROOT / f"{plugin['id']}.zip").read_bytes()

tests/page/framey_actions.mjs

@@ -28,7 +28,45 @@ assert.deepEqual(jsx.children,['Saved']);
 const fragments=window.SP_JSX.jsxs(window.SP_JSX.Fragment,{children:['one','two']});
 assert.equal(fragments.type,React.Fragment);
 assert.deepEqual(fragments.children,[['one','two']]);
-const nodes=(tree,type)=>[...(tree?.type===type?[tree]:[]),...(tree?.children||[]).flatMap(child=>nodes(child,type))];
+const nodes=(tree,type)=>Array.isArray(tree)?tree.flatMap(child=>nodes(child,type)):
+  [...(tree?.type===type?[tree]:[]),...(tree?.children||[]).flatMap(child=>nodes(child,type))];
+// Disabled controls stay inert even if a caller invokes their handlers directly.
+let changed=0;
+const toggle=nodes(window.DFL.ToggleField({label:'Enabled',checked:true,disabled:true,
+  onChange:()=>changed++}),'input')[0];
+const options=[{label:'Modes',options:[{label:'Slow',data:'slow'},{label:'Fast',data:'fast'}]}];
+const dropdown=nodes(window.DFL.Dropdown({rgOptions:options,selectedOption:'fast',disabled:true,
+  onChange:()=>changed++}),'select')[0];
+const button=nodes(window.DFL.ButtonItem({label:'Reload',description:'Read setting',disabled:true,
+  onClick:()=>changed++}),'button')[0];
+const input=nodes(window.DFL.TextField({label:'Alias',value:'Old',placeholder:'New',disabled:true,
+  onChange:()=>changed++}),'input')[0];
+const slider=nodes(window.DFL.SliderField({label:'Speed',value:2,min:0,max:10,step:2,disabled:true,
+  onChange:()=>changed++}),'input')[0];
+for(const control of [toggle,dropdown,button,input,slider])assert.equal(control.props.disabled,true);
+assert.equal(input.props.value,'Old');
+assert.equal(slider.props.type,'range');
+assert.equal(dropdown.props.value,'1');
+assert.equal(nodes(dropdown,'optgroup').length,1);
+toggle.props.onChange({target:{checked:false}});
+dropdown.props.onChange({target:{value:'0'}});
+button.props.onClick({});
+input.props.onChange({target:{value:'New'}});
+slider.props.onChange({target:{value:'4'}});
+assert.equal(changed,0);
+let entered='';
+const readyInput=nodes(window.DFL.TextField({label:'Alias',value:'Old',onChange:e=>{entered=e.target.value;}}),'input')[0];
+readyInput.props.onChange({target:{value:'New'}});assert.equal(entered,'New');
+let speed=0;
+const readySlider=nodes(window.DFL.SliderField({label:'Speed',value:2,onChange:v=>{speed=v;}}),'input')[0];
+readySlider.props.onChange({target:{value:'4'}});assert.equal(speed,4);
+let selected;
+const readyDropdown=nodes(window.DFL.Dropdown({rgOptions:options,selectedOption:'fast',
+  onChange:option=>{selected=option;}}),'select')[0];
+readyDropdown.props.onChange({target:{value:'0'}});assert.equal(selected.data,'slow');
+const readyButton=nodes(window.DFL.ButtonItem({label:'Reload',onClick:()=>changed++}),'button')[0];
+assert.equal(readyButton.props.disabled,false);
+readyButton.props.onClick({});assert.equal(changed,1);
 let called=0;
 const plugin={content:{type:'content'},settings:{type:'settings'},titleView:{type:'title'},
   frameyQuickActions:[{label:'Refresh data',onClick:async()=>{called++;return 'Fresh';}},

tests/test_frame_decky_store.py

@@ -11,6 +11,7 @@ import sys
 import tempfile
 import unittest
 from unittest.mock import patch
+import warnings
 import zipfile
 
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent / 'ui'))
@@ -54,6 +55,22 @@ class ArchiveTests(unittest.TestCase):
                 with self.assertRaises(ValueError):
                     frame_decky_store.archive_info(data, hashlib.sha256(data).hexdigest(), 'Example')
 
+    def test_rejects_zip_path_collisions_and_non_object_manifest(self):
+        for name in ('Example/dist/index.js', 'Example/./dist/index.js',
+                     'Example//dist/index.js'):
+            with self.subTest(name=name), warnings.catch_warnings():
+                warnings.simplefilter('ignore', UserWarning)
+                data, digest = archive(extra=(name, 'replacement'))
+                with self.assertRaisesRegex(ValueError, 'Unsafe|duplicate'):
+                    frame_decky_store.archive_info(data, digest, 'Example')
+        stream = io.BytesIO()
+        with zipfile.ZipFile(stream, 'w') as bundle:
+            bundle.writestr('Example/plugin.json', '[]')
+            bundle.writestr('Example/dist/index.js', ' ' * 1200)
+        data = stream.getvalue()
+        with self.assertRaisesRegex(ValueError, 'manifest'):
+            frame_decky_store.archive_info(data, hashlib.sha256(data).hexdigest(), 'Example')
+
 
 @unittest.skipIf(os.name == 'nt', 'remote plugin transaction runs on Linux')
 class StoreTransaction(unittest.TestCase):
@@ -146,6 +163,15 @@ class StoreTransaction(unittest.TestCase):
         self.assertEqual(installed.returncode, 0, installed.stderr)
         self.assertEqual(self.apply('remove').returncode, 0)
 
+    def test_remote_apply_rejects_colliding_zip_paths(self):
+        for name in ('Example/dist/index.js', 'Example/./dist/index.js'):
+            with self.subTest(name=name), warnings.catch_warnings():
+                warnings.simplefilter('ignore', UserWarning)
+                data, _ = archive(extra=(name, 'replacement'))
+                result = self.apply('install', data)
+                self.assertNotEqual(result.returncode, 0)
+                self.assertFalse(self.folder.exists())
+
 
 class StoreHost(unittest.TestCase):
     def test_stopped_managed_service_allows_removing_owned_plugin(self):

tests/test_framey_official.py

@@ -0,0 +1,45 @@
+"""The pinned store bundles remain valid API v2 Framey panel inputs."""
+import sandbox  # noqa: F401
+import base64
+import hashlib
+import json
+from pathlib import Path
+import re
+import sys
+import tempfile
+import unittest
+from unittest.mock import patch
+import zipfile
+import io
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1] / 'ui'))
+import frame_decky_store
+import framey_panel
+from framey_official import PLUGINS, archive
+
+
+class OfficialBundles(unittest.TestCase):
+    def test_pinned_store_archives_install_and_pack_into_framey_panel(self):
+        with tempfile.TemporaryDirectory() as root:
+            plugins = Path(root)
+            for plugin in PLUGINS:
+                with self.subTest(plugin=plugin['name']):
+                    data = archive(plugin)
+                    self.assertEqual(hashlib.sha256(data).hexdigest(), plugin['sha256'])
+                    self.assertEqual(frame_decky_store.archive_info(data, plugin['sha256'], plugin['name']),
+                                     plugin['folder'])
+                    with zipfile.ZipFile(io.BytesIO(data)) as z:
+                        manifest = json.loads(z.read(plugin['folder'] + '/plugin.json'))
+                        self.assertEqual(manifest['api_version'], 2)
+                        z.extractall(plugins)
+                    folder = plugins / plugin['folder']
+                    (folder / '.frame-control-store.json').write_text(json.dumps({'storeId': plugin['id']}))
+                    with patch.object(framey_panel, 'PLUGINS', plugins):
+                        page = framey_panel.panel(plugin['id']).decode()
+                    encoded = re.search(r'<script id="framey-bundle" type="application/json">([^<]+)</script>', page)
+                    self.assertIsNotNone(encoded)
+                    self.assertEqual(base64.b64decode(encoded.group(1)), (folder / 'dist/index.js').read_bytes())
+
+
+if __name__ == '__main__':
+    unittest.main()

tests/test_framey_sample.py

@@ -45,6 +45,18 @@ class SamplePlugin(unittest.TestCase):
             with self.assertRaises(ValueError): asyncio.run(plugin.set_setting('enabled', 'yes'))
             self.assertFalse((Path(folder) / 'settings.json').exists())
 
+    def test_corrupt_or_old_setting_uses_default_and_can_be_replaced(self):
+        with tempfile.TemporaryDirectory() as folder:
+            plugin = backend(folder)
+            path = Path(folder) / 'settings.json'
+            for data in ('broken JSON', '[]', '{"enabled": "yes"}'):
+                with self.subTest(data=data):
+                    path.write_text(data)
+                    self.assertFalse(asyncio.run(plugin.get_setting('enabled', False)))
+                    self.assertTrue(asyncio.run(plugin.get_setting('enabled', True)))
+            self.assertTrue(asyncio.run(plugin.set_setting('enabled', True)))
+            self.assertTrue(asyncio.run(backend(folder).get_setting('enabled', False)))
+
 
 if __name__ == '__main__':
     unittest.main()

ui/frame_decky_store.py

@@ -77,13 +77,20 @@ def archive_info(data, expected_hash, expected_name):
         folder = manifests[0].split('/')[0]
         if not SAFE_FOLDER.fullmatch(folder):
             raise ValueError('Invalid plugin folder')
+        seen = set()
         for entry in files:
             name = entry.filename
             mode = entry.external_attr >> 16
-            if ('\\' in name or name.startswith('/') or '..' in name.split('/') or
-                name.split('/')[0] != folder or entry.file_size > 30 * 1024 * 1024 or
-                mode & 0o170000 == 0o120000):
+            kind = mode & 0o170000
+            parts = name.split('/')
+            if entry.is_dir() and parts[-1] == '':
+                parts = parts[:-1]
+            if ('\\' in name or name.startswith('/') or
+                any(part in ('', '.', '..') for part in parts) or name in seen or
+                parts[0] != folder or entry.file_size > 30 * 1024 * 1024 or
+                kind not in (0, 0o040000, 0o100000)):
                 raise ValueError('Unsafe plugin archive member')
+            seen.add(name)
             if entry.is_dir():
                 continue
             with archive.open(entry) as source:
@@ -93,6 +100,8 @@ def archive_info(data, expected_hash, expected_name):
             if header[:2] == b'MZ':
                 raise ValueError('Plugin contains a Windows binary: ' + name)
         manifest = json.loads(archive.read(manifests[0]))
+        if not isinstance(manifest, dict):
+            raise ValueError('Invalid plugin manifest')
         if manifest.get('name') != expected_name:
             raise ValueError('Plugin name differs from the official store')
         flags = manifest.get('flags', [])
@@ -142,10 +151,17 @@ try:
             files=z.infolist()
             if not files or len(files)>3000 or sum(f.file_size for f in files)>150*1024*1024:
                 raise RuntimeError('Plugin archive too large')
-            if any(f.filename.split('/')[0]!=folder or f.filename.startswith('/') or
-                   '..' in f.filename.split('/') or '\\' in f.filename or
-                   f.file_size>30*1024*1024 or f.external_attr>>16&0o170000==0o120000 for f in files):
-                raise RuntimeError('Unsafe plugin archive')
+            seen=set()
+            for f in files:
+                parts=f.filename.split('/')
+                if f.is_dir() and parts[-1]=='': parts=parts[:-1]
+                kind=f.external_attr>>16&0o170000
+                if (not parts or parts[0]!=folder or f.filename.startswith('/') or
+                    any(part in ('','.','..') for part in parts) or '\\' in f.filename or
+                    f.filename in seen or f.file_size>30*1024*1024 or
+                    kind not in (0,0o040000,0o100000)):
+                    raise RuntimeError('Unsafe plugin archive')
+                seen.add(f.filename)
             stage.mkdir(mode=0o700)
             z.extractall(stage)
             unpacked=stage/folder

ui/framey-host.js

@@ -46,13 +46,38 @@
   const passthrough = tag => ({children, ...props}) => R.createElement(tag, props, children);
   const Field = ({label, description, children}) => R.createElement('label', null,
     R.createElement('strong', null, label), description && R.createElement('small', null, description), children);
-  const ToggleField = ({label, description, checked, onChange}) => R.createElement(Field, {label, description},
-    R.createElement('input', {type:'checkbox', checked:!!checked, onChange:e=>onChange?.(e.target.checked)}));
-  const DropdownItem = ({label, description, rgOptions=[], selectedOption, onChange}) => R.createElement(Field, {label, description},
-    R.createElement('select', {value:String(selectedOption ?? ''), onChange:e=>onChange?.(rgOptions.find(x=>String(x.data)===e.target.value))},
-      rgOptions.map(x=>R.createElement('option', {key:String(x.data), value:String(x.data)}, x.label))));
-  const ButtonItem = ({label, children, onClick}) => R.createElement(Field, {label},
-    R.createElement('button', {type:'button', onClick}, children || label));
+  const ToggleField = ({label, description, checked, disabled, onChange}) => R.createElement(Field, {label, description},
+    R.createElement('input', {type:'checkbox', checked:!!checked, disabled:!!disabled,
+      onChange:e=>{if(!disabled)onChange?.(e.target.checked);}}));
+  const DropdownItem = ({label, description, rgOptions=[], selectedOption, disabled, strDefaultLabel, onChange}) => {
+    const choices=[];
+    const option = entry => {
+      const index=choices.push(entry)-1;
+      return R.createElement('option', {key:index, value:String(index)}, entry.label);
+    };
+    const entries=(Array.isArray(rgOptions) ? rgOptions : []).map(entry =>
+      Array.isArray(entry.options) ? R.createElement('optgroup', {key:String(entry.label), label:String(entry.label)},
+        entry.options.map(option)) : option(entry));
+    const selected=choices.findIndex(entry=>Object.is(entry.data, selectedOption));
+    return R.createElement(Field, {label, description}, R.createElement('select', {
+      value:selected < 0 ? '' : String(selected), disabled:!!disabled,
+      onChange:e=>{const entry=choices[Number(e.target.value)];if(!disabled && entry)onChange?.(entry);}},
+      selected < 0 && R.createElement('option', {value:'', disabled:true}, strDefaultLabel || 'Choose an option'),
+      entries));
+  };
+  const ButtonItem = ({label, description, children, disabled, onClick}) => R.createElement(Field, {label, description},
+    R.createElement('button', {type:'button', disabled:!!disabled,
+      onClick:e=>{if(!disabled)onClick?.(e);}}, children || label));
+  const TextField = ({label, description, value, placeholder, disabled, bIsPassword,
+    mustBeNumeric, mustBeURL, mustBeEmail, onChange}) => R.createElement(Field, {label, description},
+    R.createElement('input', {type:bIsPassword?'password':mustBeNumeric?'number':mustBeURL?'url':mustBeEmail?'email':'text',
+      value, placeholder, disabled:!!disabled, onChange:e=>{if(!disabled)onChange?.(e);}}));
+  const SliderField = ({label, description, value, min=0, max=100, step=1, disabled, showValue,
+    valueSuffix='', onChange}) => R.createElement(Field, {label, description},
+    R.createElement('input', {type:'range', value, min, max, step, disabled:!!disabled,
+      'aria-label':typeof label==='string'?label:undefined,
+      onChange:e=>{if(!disabled)onChange?.(Number(e.target.value));}}),
+    showValue && R.createElement('span', null, String(value) + valueSuffix));
   const PanelSection = ({title, children}) => R.createElement('section', null,
     title && R.createElement('h2', null, title), children);
   const ConfirmModal = ({strTitle, strOKButtonText, onOK, children}) => R.createElement('section', null,
@@ -80,7 +105,8 @@
   };
   const DFL = window.DFL = {
     definePlugin: init => init,
-    PanelSection, PanelSectionRow: passthrough('div'), Field, ToggleField, DropdownItem, ButtonItem,
+    PanelSection, PanelSectionRow: passthrough('div'), Field, ToggleField, DropdownItem,
+    Dropdown: DropdownItem, ButtonItem, TextField, SliderField,
     Focusable: passthrough('div'), ScrollPanel: passthrough('div'), ScrollPanelGroup: passthrough('div'),
     DialogButton: passthrough('button'), ConfirmModal,
     staticClasses: {Title:'framey-title'},