Clear stale Framey job IDs after app restart

docs/framey-loader.md

@@ -66,7 +66,9 @@ The store verifies each downloaded archive and the headset applies it with a
 rollback if Decky cannot start. The panel remembers the current job ID for this
 browser session, so **Check result** can resume polling after a navigation or
 temporary connection error. Refresh the installed list before starting another
-operation after an error.
+operation after an error. If Frame Control restarts, it cannot recover the old
+job result. The panel clears that job ID and asks you to refresh the installed
+list before making another change.
 
 ## For plugin authors
 

tests/page/framey_store.mjs

@@ -70,3 +70,17 @@ vm.runInContext('api=mockApi',ctx);
 await vm.runInContext('deckyChange("update",{id:2,name:"Plugin 2"})',ctx);
 assert.match(el('deckyJobStatus').textContent,/Error: archive digest mismatch/);
 assert.equal(session.has('frameyPluginJob'),false);
+
+// A saved job does not survive a server restart. Clear it instead of offering
+// Check result forever for an ID that the new server cannot know.
+session.set('frameyPluginJob',JSON.stringify({job:'old-job',action:'install',name:'Plugin 2'}));
+ctx.mockApi=async path => {
+  if(path.startsWith('/api/job'))throw Error('no such job (the app may have restarted)');
+  if(path==='/api/decky')return {running:true,plugins:[]};
+  throw Error(`unexpected ${path}`);
+};
+vm.runInContext('api=mockApi',ctx);
+await vm.runInContext('checkDeckyJob()',ctx);
+assert.match(el('deckyJobStatus').textContent,/app restarted and lost this job result/);
+assert.equal(el('deckyJobCheck').hidden,true);
+assert.equal(session.has('frameyPluginJob'),false);

ui/headset.html

@@ -148,7 +148,15 @@ function deckyJobView(title,message,percent,failed=false){
 }
 async function followDeckyJob(job,action,name){
   for(let n=0;n<180;n++){
-    const progress=await api(`/api/job?id=${encodeURIComponent(job)}`);
+    let progress;
+    try{progress=await api(`/api/job?id=${encodeURIComponent(job)}`);}
+    catch(error){
+      if(/no such job/i.test(error.message)){
+        sessionStorage.removeItem('frameyPluginJob');
+        throw Error('The app restarted and lost this job result. Refresh installed plugins to see what changed.');
+      }
+      throw error;
+    }
     if(progress.done){if(progress.error){sessionStorage.removeItem('frameyPluginJob');throw Error(progress.error);}
       deckyJobView(`${action} ${name}`,progress.message||`${action} complete`,100);return;}
     deckyJobView(`${action} ${name}`,progress.stage||'Waiting for Frame…',progress.percent);
@@ -168,7 +176,7 @@ async function deckyChange(action,plugin){if(deckyBusy||!confirm(`${action} ${pl
   finally{deckyBusy=false;await refreshDecky();}
 }
 async function checkDeckyJob(){let saved;try{saved=JSON.parse(sessionStorage.getItem('frameyPluginJob')||'null');}catch(_){saved=null;}
-  if(!saved||typeof saved.job!=='string')return;
+  if(!saved||typeof saved.job!=='string'){sessionStorage.removeItem('frameyPluginJob');return;}
   deckyBusy=true;byId('deckyJobCheck').hidden=true;
   try{await followDeckyJob(saved.job,saved.action,saved.name);sessionStorage.removeItem('frameyPluginJob');}
   catch(error){deckyJobView(`${saved.action} ${saved.name}`,`Error: ${error.message}`,null,true);}